Why does everyone act like being cynical is a bad thing?

I agree with you almost entirely. Cynical = realism. People who are optimistic are not realistic. They are in denial. I'm not an atheist, though, but otherwise I agree with you.